Move implementation from SDK header files to SDK cc

[perhapsmaple]

Contributes to #1429

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[codecov]

Codecov Report

❌ Patch coverage is 87.50000% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (e8c5ee2) to head (6ed44fb).

Files with missing lines	Patch %	Lines
sdk/src/metrics/view/view_registry.cc	81.04%	11 Missing ⚠️
sdk/src/metrics/aggregation/drop_aggregation.cc	0.00%	7 Missing ⚠️
sdk/src/trace/multi_recordable.cc	89.40%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3887      +/-   ##
==========================================
+ Coverage   90.12%   90.13%   +0.02%     
==========================================
  Files         227      230       +3     
  Lines        7261     7293      +32     
==========================================
+ Hits         6543     6573      +30     
- Misses        718      720       +2     

Files with missing lines	Coverage Δ
...lemetry/sdk/metrics/aggregation/drop_aggregation.h	66.67% <ø> (+44.45%)	⬆️
...ude/opentelemetry/sdk/metrics/view/view_registry.h	100.00% <ø> (+18.65%)	⬆️
sdk/include/opentelemetry/sdk/trace/span_data.h	100.00% <ø> (ø)
sdk/src/common/empty_attributes.cc	100.00% <100.00%> (ø)
sdk/src/logs/multi_recordable.cc	90.42% <100.00%> (ø)
sdk/src/trace/span_data.cc	100.00% <100.00%> (ø)
sdk/src/metrics/aggregation/drop_aggregation.cc	0.00% <0.00%> (ø)
sdk/src/trace/multi_recordable.cc	89.40% <89.40%> (ø)
sdk/src/metrics/view/view_registry.cc	81.04% <81.04%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marcalff]

Thanks for the fix.

This has a good size already, so please stabilize this PR to make it ready for review and merge. More files can be changed in a different PR, if so inclined.

To fix:

• IWYU build failures
  • look for "Warning: include-what-you-use reported diagnostics:" in the build logs, in section iwyu_tool
• Resolve merge conflicts
• clang-format

[lalitb]

GetEmptyAttributes() was previously a static free function (header-only, internal linkage). It's now an externally-linked symbol requiring linkage against opentelemetry_common. While this shouldn't be an issue in practice, someone could theoretically be including this header standalone without linking the SDK - for their own utility purposes - and that would now fail with an undefined symbol error. Please add a CHANGELOG entry noting this change.

[lalitb]

Thanks for the PR. LGTM once the CI and merge conflict are resolved.

[ThomsonTan]

Move this and SpanDataLink::GetAttributes to .cc for consistency, since SpanData::GetAttributes has been moved to .cc.

[lalitb]

@perhapsmaple - Would you be resolving the remaining comments, so it can be merged. thanks.

[perhapsmaple]

@lalitb Sorry I've been a little busy the last couple of weeks. Please give me a couple of days time to fix the remaining comments

[marcalff]

When moving code from x.h to x.cc, make sure to preserve the clang-tidy cleanup implemented in x.h recently, if any, when merging with a recent main.

[ThomsonTan]

Seems this is not added to CMakeLists.txt?

[perhapsmaple]

Good catch. I also found circular_buffer_test which is in CMake but missing from Bazel