feat: rename Call activity to Not reached#726
Open
anonymoususer72041 wants to merge 3 commits intoopencats:masterfrom
Open
feat: rename Call activity to Not reached#726anonymoususer72041 wants to merge 3 commits intoopencats:masterfrom
anonymoususer72041 wants to merge 3 commits intoopencats:masterfrom
Conversation
anonymoususer72041
force-pushed
the
feat/rename-call-to-not-reached
branch
from
6bacd4c to
2585a82
Compare
Contributor
Author
|
I wonder why Behat did not fail before commit 2585a82... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the existing
Callactivity toNot reached.The change updates the default schema for new installations, adjusts the relevant UI code paths that still used the
Calllabel directly and adds a database migration so existing installations are updated as well.The related activity types
Call (Talked),Call (LVM)andCall (Missed)remain unchanged.Motivation
The activity labels
CallandCall (Talked)are too close to each other and can be confusing in daily use.Using
Not reachedmakes the distinction clearer, because it separates unsuccessful contact attempts from successful calls more explicitly.This improves the activity selection and makes the intent of the existing activity type easier to understand without changing its underlying ID or behavior.