Skip to content

feat: merge session's environment settings before sending request#102

Merged
gounux merged 3 commits intomasterfrom
feat/merge-session-environment-settings-before-send
Mar 30, 2026
Merged

feat: merge session's environment settings before sending request#102
gounux merged 3 commits intomasterfrom
feat/merge-session-environment-settings-before-send

Conversation

@gounux
Copy link
Copy Markdown
Member

@gounux gounux commented Mar 19, 2026

This PR intends to allow the usage of the REQUESTS_CA_BUNDLE environment variable, if there is a need to use custom CAs. Before, the behavior of this potential env variable was overridden by the boolean verify_ssl, set to True by default.

Before this PR, the requests process was not making use of the environment, which is now the case as stated in the doc. So, potential HTTP environment variables like http_proxy or NO_PROXY may now be active.

This allow especially to use the `REQUESTS_CA_BUNDLE` env variable, which was overriden by `verify_ssl`
Copy link
Copy Markdown
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution!

@gounux gounux merged commit e39df96 into master Mar 30, 2026
8 checks passed
@gounux gounux deleted the feat/merge-session-environment-settings-before-send branch March 30, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants