Open
Conversation
664bcff to
820016d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a complete log aggregation pipeline to the observability stack. Pod stdout/stderr logs from all nodes are collected by a new OpenTelemetry Collector DaemonSet, enriched with Kubernetes metadata, and stored in Victoria Logs — a high-performance log storage backend by
VictoriaMetrics. The Victoria Logs UI is exposed through the same shared Envoy Gateway used for Prometheus, using HTTPS + mTLS client certificate authentication.
Key changes:
ObservabilityStackCR.log-collector.yaml): reads/var/log/podson every node, handles both Docker JSON and containerd/CRI-O log formats, extracts pod metadata (namespace, pod name, uid, container) from the file path, promotes JSON-structured log fields to indexedattributes, and ships logs to Victoria Logs via OTLP HTTP.
kustomizations/observability-gateway/, removing the previously per-component gateway setup fromkustomizations/prometheus/.otlp-logs.<gw-ns>.<base-domain>:8443) accepts logs from external Kubernetes clusters.k8s_clusterresource attribute is injected via theresourceprocessor, allowing logs from multiple clusters to be differentiated in Victoria Logs queries.test/e2e/victoria-logs.go+ assess step inobs_stack_test.gothat port-forwards to Victoria Logs and verifies at least one log entry is ingested within 10 minutes.Which issue(s) this PR fixes:
Fixes openmcp-project/backlog#524
Special notes for your reviewer:
The Prometheus gateway resources have been deleted from
kustomizations/prometheus/and replaced by the consolidatedkustomizations/observability-gateway/. Theobservability-gatewayRGD now manages certs and gateway configuration for both Prometheus and Victoria Logs(including the OTLP ingestion endpoint). Reviewers should pay attention to the patch ordering in
resource-graph-definitions/observability-gateway.yamlto ensure hostname and cert DNS SANs are set correctly.Release note: