Open
Conversation
for more information, see https://pre-commit.ci
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
…into issue1564
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
===========================================
+ Coverage 52.73% 80.11% +27.37%
===========================================
Files 37 62 +25
Lines 4399 5130 +731
===========================================
+ Hits 2320 4110 +1790
+ Misses 2079 1020 -1059 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openml#1576 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
for more information, see https://pre-commit.ci
…into runs-migration-stacked
This reverts commit 93155ee.
geetu040
suggested changes
Mar 13, 2026
Collaborator
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
update with #1576 (comment)
…into runs-migration-stacked
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 42 out of 43 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+6
| from __future__ import annotations | ||
|
|
||
| import hashlib | ||
| import json | ||
| import logging | ||
| import math |
Comment on lines
+27
to
+35
| @pytest.fixture | ||
| def dummy_task_v2(http_client_v2, minio_client) -> DummyTaskV1API: | ||
| return DummyTaskV2API(http=http_client_v2, minio=minio_client) | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def dummy_task_fallback(dummy_task_v1, dummy_task_v2) -> DummyTaskV1API: | ||
| return FallbackProxy(dummy_task_v2, dummy_task_v1) | ||
|
|
Comment on lines
46
to
48
| def _mocked_perform_api_call(call, request_method): | ||
| url = openml.config.server + "/" + call | ||
| url = openml.config.server + call | ||
| return openml._api_calls._download_text_file(url) |
Comment on lines
+201
to
+207
| openml.config._set_servers(mode) | ||
| openml.config.set_api_version(api_version) | ||
| openml.config.server = "temp-server1" | ||
| openml.config.apikey = "temp-apikey1" | ||
| openml.config._get_servers(mode)["server"] = 'temp-server2' | ||
| openml.config._get_servers(mode)["apikey"] = 'temp-server2' | ||
|
|
Comment on lines
+1
to
+6
| from __future__ import annotations | ||
|
|
||
| from enum import Enum | ||
|
|
||
|
|
||
| class APIVersion(str, Enum): |
Comment on lines
+10
to
11
| from urllib.parse import urljoin | ||
|
|
Comment on lines
+12
to
13
| from urllib.parse import urlparse | ||
|
|
Comment on lines
+296
to
+302
| f"allowed versions: {', '.join(list(APIVersion))}" | ||
| ) | ||
|
|
||
| if fallback_api_version is not None and fallback_api_version not in APIVersion: | ||
| raise ValueError( | ||
| f'invalid fallback_api_version="{fallback_api_version}" ' | ||
| f"allowed versions: {', '.join(list(APIVersion))}" |
Comment on lines
+87
to
+89
| attr = getattr(api, name, None) | ||
| if attr is not None: | ||
| return api, attr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
fixes #1624