Conversation
#24) * Fix tests under SwiftPM (also when opening Xcode using Package.swift file) * Simplified if structure
…e/console-ios-lib into enhancement/swift-lint
…dependencies in consuming projects)
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public func setDomain(domain: String) async throws -> ConfigManagerState { | ||
| public func setDomain(domain: String) async throws -> ConfigManagerState { |
Check warning
Code scanning / SwiftLint
Function should have complexity 10 or less; currently complexity is 18 Warning
| } | ||
|
|
||
| public func setDomain(domain: String) async throws -> ConfigManagerState { | ||
| public func setDomain(domain: String) async throws -> ConfigManagerState { |
Check warning
Code scanning / SwiftLint
Function body should span 50 lines or less excluding comments and whitespace: currently spans 72 lines Warning
|
Miggets7
left a comment
Miggets7
left a comment
There was a problem hiding this comment.
Looks good to me. Should help us out with formatting!
ebariaux
dismissed
Miggets7’s stale review
The merge-base changed after approval.
|
closes #20 |
4 participants
Added SwiftLint to the build, both locally in Xcode and in the CI/CD pipeline.
Fixed most of the issues that SwiftLint did indicate but some warnings are still present and should be addressed in specific GH issues as this will require some more refactoring / code changes or are potentially already covered by other planned tasks.
Also tests sometimes fail in this action, this is a known issue, see #19