OCPBUGS-79358: pkg/cvo/egress: Disable Proxy respect on HyperShift#1357
OCPBUGS-79358: pkg/cvo/egress: Disable Proxy respect on HyperShift#1357wking wants to merge 1 commit intoopenshift:mainfrom
Conversation
Since 4.14, HostedCluster has had spec.configuration.proxy to configure the data-plane egress [1]. In 4.18, the HyperShift API began documenting that setting as specific to data-plane egress [2]. However, the cluster-version operator running on the management-cluster control plane has assumed that hosted-cluster Proxy resource should configure its own egress as well. I’m not sure how folks expect management-cluster-side control-plane egress to be configured, but we don’t want it to respect spec.configuration.proxy, because management-cluster networking and data-plane-compute networking are very different environments. For now, just ignore the knob on HyperShift, to avoid data-plane-specific-network-config breaking Update Service access, with ClusterVersionRetrievedUpdates messages like: Unable to retrieve available updates: Get "https://api.openshift.com/api/upgrades_info/v1/graph?...": proxyconnect tcp: dial tcp: lookup ... on ...:53: no such host [1]: https://github.com/openshift/hypershift/blame/b11c804b44516f34e50344eeb94901936018d9d1/api/v1beta1/hostedcluster_types.go#L2165-L2167 [2]: https://github.com/openshift/hypershift/blame/0d2075c649ed99657f6c5f90a0d273b8f99e9bc2/api/hypershift/v1beta1/hostedcluster_types.go#L1719-L1727
openshift-ci-robot
added
jira/severity-moderate
|
@wking: This pull request references Jira Issue OCPBUGS-79358, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Since 4.14, HostedCluster has had spec.configuration.proxy to configure the data-plane egress 1. In 4.18, the HyperShift API began documenting that setting as specific to data-plane egress 2. However, the cluster-version operator running on the management-cluster control plane has assumed that hosted-cluster Proxy resource should configure its own egress as well. I’m not sure how folks expect management-cluster-side control-plane egress to be configured, but we don’t want it to respect spec.configuration.proxy, because management-cluster networking and data-plane-compute networking are very different environments. For now, just ignore the knob on HyperShift, to avoid data-plane-specific-network-config breaking Update Service access, with ClusterVersionRetrievedUpdates messages like: