feat(core): Make namespacing subject mappings and condition sets optional by c-r33d · Pull Request #776 · opentdf/otdfctl

c-r33d · 2026-03-13T16:06:49Z

1.) Optionally allows a customer to namespace a subject mapping or subject condition set. The requirement will be driven by the server
2.) Pin to a platform feature branch to unravel the circular deps.

…ck xtest.

gemini-code-assist · 2026-03-13T16:07:23Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the policy management system by introducing optional namespacing for subject mappings and subject condition sets. This change provides users with the flexibility to organize and manage these policy components within defined namespaces, improving clarity and control, especially in complex environments. The updates span across CLI commands, internal handling logic, and documentation to seamlessly integrate this new capability.

Highlights

Optional Namespacing: Introduced an optional 'namespace' flag for the creation of subject mappings and subject condition sets, allowing users to associate these entities with a specific namespace.
CLI Command Updates: Updated the otdfctl policy subject-condition-set create and otdfctl policy subject-mapping create commands to accept and process the new optional --namespace flag.
Handler Logic Enhancement: Modified the internal handler functions to correctly parse the provided namespace (as either an ID or FQN) and include it in the respective creation requests to the backend service.
Documentation Updates: Updated the CLI documentation for subject condition set and subject mapping creation commands to reflect the new namespace flag and provide usage examples.
Dependency Update: Updated the github.com/opentdf/platform/protocol/go dependency to a newer version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

cmd/policy/subjectConditionSets.go
- Added an optional 'namespace' flag to the createSubjectConditionSet command.
- Modified the call to CreateSubjectConditionSet to pass the new namespace.
- Included namespace FQN in the output display if a namespace is present.
cmd/policy/subjectMappings.go
- Added an optional 'namespace' flag to the policyCreateSubjectMapping command.
- Modified the call to CreateNewSubjectMapping to pass the new namespace.
- Included namespace FQN in the output display if a namespace is present.
docs/man/policy/subject-condition-sets/create.md
- Documented the new 'namespace' flag for the create command.
- Updated example usage to include the --namespace flag.
docs/man/policy/subject-mappings/create.md
- Documented the new 'namespace' flag for the create command.
- Updated example usage to include the --namespace flag.
go.mod
- Updated the version of github.com/opentdf/platform/protocol/go.
go.sum
- Updated checksums for the github.com/opentdf/platform/protocol/go dependency.
pkg/handlers/subjectConditionSets.go
- Modified the CreateSubjectConditionSet function signature to accept a namespace string.
- Implemented logic to parse the namespace into an ID or FQN and include it in the creation request.
pkg/handlers/subjectmappings.go
- Imported the github.com/google/uuid package.
- Added a parseNamespaceIDOrFQN helper function to distinguish between namespace ID and FQN.
- Modified the CreateNewSubjectMapping function signature to accept a namespace string.
- Implemented logic to parse the namespace into an ID or FQN and include it in the creation request.

Activity

No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces optional namespacing for subject mappings and condition sets, which is a valuable feature. The implementation is straightforward, adding a namespace flag to the relevant CLI commands and passing it through to the backend services. The documentation has also been updated accordingly. I've identified a couple of areas for improvement related to code duplication and configuration consistency, which I've detailed in the comments.

gemini-code-assist · 2026-03-13T16:09:03Z

docs/man/policy/subject-mappings/create.md

  flags:
+    - name: namespace
+      description: Optional namespace ID or FQN for the subject mapping and any newly created subject condition set
+      required: false


For consistency with other flag definitions (like in docs/man/policy/subject-condition-sets/create.md), it's best to explicitly add default: '' for the optional namespace flag. While the behavior might be correct without it due to zero-value defaults, explicitly defining it improves the clarity and robustness of the command definition parsing.

Suggested change

required: false

required: false

default: ''

gemini-code-assist · 2026-03-13T16:09:03Z

pkg/handlers/subjectmappings.go

+	if namespace != "" {
+		namespaceID, namespaceFQN := parseNamespaceIDOrFQN(namespace)
+		if namespaceID != "" {
+			req.NamespaceId = namespaceID
+		} else {
+			req.NamespaceFqn = namespaceFQN
+		}
+	}


This logic for setting the namespace on the request is duplicated in pkg/handlers/subjectConditionSets.go. To improve maintainability and avoid future bugs, consider extracting this logic into a private helper function within the handlers package. This function could be used in both CreateNewSubjectMapping and CreateSubjectConditionSet to centralize the namespace handling.

github-actions · 2026-03-13T16:26:05Z

X-Test Failure Report

✅ go-v0.9.0
✅ java-v0.9.0
✅ js-v0.9.0
test-cases-mapping-report
bats-test-results

c-r33d added 2 commits March 13, 2026 08:59

add the ability to create subject mapping and condition set, to unblo…

17196fb

…ck xtest.

allow subject mapping and condition sets to be optional for xtest.

dd76753

gemini-code-assist bot reviewed Mar 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): Make namespacing subject mappings and condition sets optional#776

feat(core): Make namespacing subject mappings and condition sets optional#776
c-r33d wants to merge 2 commits intomainfrom
ns-scs-sm

c-r33d commented Mar 13, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Mar 13, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 13, 2026

Uh oh!

gemini-code-assist bot Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

c-r33d commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Mar 13, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 13, 2026

X-Test Failure Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

c-r33d commented Mar 13, 2026 •

edited

Loading