Open
Conversation
tn-m
commented
Jul 26, 2023
Comment on lines
-5
to
+6
| documents: ["src/**/*.tsx"], | ||
| ignoreNoDocuments: true, // for better experience with the watcher | ||
| documents: ["src/**/*.gql"], | ||
| // ignoreNoDocuments: true, // for better experience with the watcher |
Author
There was a problem hiding this comment.
I prefer to split gql into another file, but it's up to you
Comment on lines
-8
to
+10
| "./src/gql/": { | ||
| preset: "client", | ||
| "./src/gql/generated.ts": { | ||
| plugins: ["typescript", "typescript-operations", "typed-document-node"], | ||
| // preset: "client", |
Comment on lines
-6
to
+8
| import { graphql } from "../src/gql"; | ||
|
|
||
| const allFilmsWithVariablesQueryDocument = graphql(/* GraphQL */ ` | ||
| query allFilmsWithVariablesQuery($first: Int!) { | ||
| allFilms(first: $first) { | ||
| edges { | ||
| node { | ||
| ...FilmItem | ||
| } | ||
| } | ||
| } | ||
| } | ||
| `); | ||
| import { | ||
| AllFilmsWithVariablesQueryDocument, | ||
| AllFilmsWithVariablesQueryQueryVariables, | ||
| } from "./gql/generated"; |
Author
There was a problem hiding this comment.
Instead of writing query in tsx, you can import the types like this
Comment on lines
+1
to
-17
| import { Film as GqlFilm } from "./gql/generated"; | ||
|
|
||
| const Film = (props: { | ||
| /* `film` property has the correct type 🎉 */ | ||
| film: FragmentType<typeof FilmFragment>; | ||
| film: GqlFilm; | ||
| }) => { | ||
| const film = useFragment(FilmFragment, props.film); |
Author
There was a problem hiding this comment.
Instead of useFragment, there are a type Film which is auto generated.
In this case conflicting to the component name though
Comment on lines
+1
to
+9
| query allFilmsWithVariablesQuery($first: Int!) { | ||
| allFilms(first: $first) { | ||
| edges { | ||
| node { | ||
| ...FilmItem | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR shows the document node feature, how it looks like. It's ok to merge if you want, but not expected as of now.
Added some plugins
Preset has document node, however does not load
.gqlfile, just.ts/.tsxcolocation is supported.It's up to you which you prefer to use
dotansimha/graphql-code-generator#8296 (comment)