feat(docker): add hostname and dns to container create#347
Merged
Conversation
Add optional hostname and dns fields to the Docker container create flow across all layers: OpenAPI spec, job types, provider, agent processor, API handler, SDK types, and SDK client. Both fields are validated at the API layer (hostname max 253 chars, dns entries must be valid IPs). Tests added at every layer. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 441 441
Lines 21496 21510 +14
=======================================
+ Hits 21477 21491 +14
Misses 11 11
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostnameanddnsoptional fields toDockerCreateRequestfor setting container hostname and custom DNS servers at creation timehostnamemax 253 chars,dnsvalidates each entry as IP addressCoverage (no regression)
controller/api/node/dockerprovider/container/dockerTest plan
🤖 Generated with Claude Code