Skip to content

#425: Storybook Stories & Documentation#433

Open
ethanluc7 wants to merge 45 commits intomainfrom
425-storybook-documentation
Open

#425: Storybook Stories & Documentation#433
ethanluc7 wants to merge 45 commits intomainfrom
425-storybook-documentation

Conversation

@ethanluc7
Copy link
Copy Markdown
Contributor

Related to issue: #425

Summary

Adds new stories for EntityRelationshipDiagram, SchemaNode, Filter Dropdown components. Also removes legacy SchemaRelationDiagram stories and unnecessary viewport testing story.

Description of Changes

  • New story file: FilterDropdowns — 5 stories covering Default, SingleFilter, FilterSelected, EmptyState, NoConfig
  • New story file: EntityRelationshipDiagram/EntityRelationshipDiagram — Moved from top-level, added autodocs and per-story descriptions for all 12 topology variants
  • New story file: EntityRelationshipDiagram/SchemaDiagramNode — Replaced legacy viewer-diagram stories with the current SchemaNode component
  • Updated intro page — index.mdx now uses the current RelationshipDiagramContent instead of the legacy SchemaRelationshipDiagram
  • Removed: stories/viewer-diagram/ (legacy), DictionaryViewerViewport stories, WithSingleFilter/WithFilterDropdowns from DictionaryPage (moved to separate storybook story)

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
    • I have checked all updates to correct typos and misspellings
  • Formatting
    • Code follows the project style guide
    • Automated code formatters (ie. Prettier) have been run
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

@ethanluc7 ethanluc7 requested a review from JamesTLopez March 26, 2026 13:14
Copy link
Copy Markdown

@JamesTLopez JamesTLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks for the clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants