Draft
Conversation
Signed-off-by: Bryan Richter <b@chreekat.net>
This is modeled after the machinery in behavioral-model and ptf, with some internal cleanups. Signed-off-by: Bryan Richter <b@chreekat.net>
chreekat
force-pushed
the
b/automated-release
branch
from
eabe31b to
e02fb0b
Compare
Author
|
CI failure is an unexpected checksum when pulling some dependency: |
Author
|
I discovered that if I start relying on a VERSION file, we'd have two sources of truth. E.g. bmv2 uses a script to read that file inside configure.ac. I think I'll just copy what bmv2 does there. Still need to check if there are more such cases of duplication. |
Contributor
Can you elaborate? At least for BMv2 we should get rid of autotools soon. |
Contributor
|
Could you also add a form of this? https://github.com/p4lang/behavioral-model/blob/main/.github/release.yml The automated release notes are useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is modeled after the machinery in behavioral-model and ptf, with some internal cleanups.
Tbh I'm not sure which repos it's appropriate to have automatic releases for? Is PI appropriate? :) Are there more I should do?