fix: handle SCAFFOLD_MANIFEST.yml (underscore) in downloaded release tarballs#178
Draft
fix: handle SCAFFOLD_MANIFEST.yml (underscore) in downloaded release tarballs#178
Conversation
Copilot
AI
changed the title
[WIP] Fix aidd create URL always fails issue
fix: handle SCAFFOLD_MANIFEST.yml (underscore) in downloaded release tarballs
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub release tarballs convert hyphens to underscores in filenames, so
SCAFFOLD-MANIFEST.ymlarrives asSCAFFOLD_MANIFEST.yml, causingaidd create <url>to always fail with a manifest-not-found error.Changes
lib/scaffold-resolver.js— AddedresolveManifestPath(dir)that checks forSCAFFOLD-MANIFEST.ymlfirst, then falls back toSCAFFOLD_MANIFEST.yml.downloadExtensionnow calls this after extraction instead of hardcoding the hyphen form. ExportsresolveManifestPathandSCAFFOLD_MANIFEST_NAMESfor consumers.lib/scaffold-create.js—runCreatenow derives the manifest filename frompath.basename(paths.manifestPath)rather than hardcodingSCAFFOLD-MANIFEST.yml, so the correct variant is passed torunManifestafter copying to the destination folder.Tests — Two new cases in
scaffold-resolver.test.js(underscore fallback, hyphen preference when both exist); one new case inscaffold-create.test.js(underscore manifest path propagated torunManifestFn).