refactor: Bump @parse/node-apn from 7.1.0 to 8.0.0#544
refactor: Bump @parse/node-apn from 7.1.0 to 8.0.0#544mtrezza merged 1 commit intoparse-community:masterfrom
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. |
📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.2.510)package.json2026-03-31 13:31:46,816 [MainThread ] [ERROR] Template file not found: package.json ... [truncated 2547 characters] ... [MainThread ] [WARNI] Secret scanning: could not process file package.json Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1172 1172
=========================================
Hits 1172 1172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 27: The dependency "@parse/node-apn" is pinned to a non-existent "8.0.0"
and will break installs; update the package.json entry for "@parse/node-apn" to
the published latest stable "7.1.0" (or, if 8.0.0 is intentionally
private/unreleased, replace the version with the correct registry/git URL or
document the private registry) and then verify src/APNS.js usage of Provider,
Notification and related properties still works against 7.1.0.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0ded8d83-3645-4af6-b394-085eabaed190
📒 Files selected for processing (2)
package-lock.jsonpackage.json
👮 Files not reviewed due to content moderation or server errors (1)
- package-lock.json
| "license": "MIT", | ||
| "dependencies": { | ||
| "@parse/node-apn": "7.1.0", | ||
| "@parse/node-apn": "8.0.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For @parse/node-apn` version 8.0.0, confirm whether these APIs are still valid and unchanged:
- new apn.Provider(options)
- new apn.Notification()
- Notification methods: setAlert, setTitle, setBadge, setSound, setContentAvailable, setMutableContent, setTargetContentIdentifier, setInterruptionLevel, setCategory, setThreadId
- Notification properties: aps, payload, id, collapseId, requestId, channelId, pushType, topic, expiry, priority
Please provide links to official docs/changelog/release notes.`
💡 Result:
No, @parse/node-apn version 8.0.0 does not exist. The latest version is 7.1.0 (published Jan 31, 2026). Therefore, the APIs cannot be confirmed for a non-existent version. For the current latest version 7.1.0, the APIs are valid and unchanged based on the official README and documentation: 1. new apn.Provider(options) - Valid. Example: const apnProvider = new apn.Provider(options); 2. new apn.Notification - Valid. Example: let note = new apn.Notification; 3. Notification methods (setAlert, setTitle, setBadge, setSound, setContentAvailable, setMutableContent, setTargetContentIdentifier, setInterruptionLevel, setCategory, setThreadId) - Valid. Examples include note.alert, note.title (implied setTitle), note.badge, note.sound. Other methods like setContentAvailable etc. are standard and unchanged per docs/tree. 4. Notification properties (aps, payload, id, collapseId, requestId, channelId, pushType, topic, expiry, priority) - Valid. Examples: note.payload, note.topic, note.expiry, note.badge (part of aps), note.collapseId implied. Official documentation and README: https://www.npmjs.com/package/@parse/node-apn GitHub repo: https://github.com/parse-community/node-apn No changelog explicitly listing breaking changes to these APIs in recent releases (v6.x to v7.1.0 add features like broadcast support but core constructors/methods unchanged). Version history shows no v8.0.0; releases up to 7.1.0 with incremental features (e.g., Node 18/20 support in v6.0.0, broadcast in v6.3/6.4). No evidence of deprecation or changes to listed APIs.
Citations:
- 1: https://www.npmjs.com/@parse/node-apn
- 2: https://www.npmjs.com/package/@parse/node-apn?activeTab=versions
- 3: https://www.npmjs.com/package/@parse/node-apn
- 4: https://github.com/node-apn/node-apn
- 5: https://www.npmjs.com/package/@parse/node-apn/v/5.1.0
- 6: https://app.unpkg.com/%40parse/node-apn%407.1.0/files/README.md
- 7: feat: Add the ability to manage channels and send broadcasts node-apn#164
- 8: Release v4.1.0 node-apn#70
- 9: Release v3.2.0 node-apn#21
- 10: feat: Add support for Node 18, 20 drop support for Node 12 node-apn#137
- 11: feat: Add support for broadcast push notifications node-apn#163
- 12: https://www.parseplatform.org
@parse/node-apn version 8.0.0 does not exist
Line 27 specifies "@parse/node-apn": "8.0.0", but the latest published version is 7.1.0 (released Jan 31, 2026). This will cause npm install to fail. Either update to the latest stable version (7.1.0) or clarify if 8.0.0 is an unreleased/private version. All APIs used in src/APNS.js (Provider constructor, Notification methods, and properties) are supported in 7.1.0.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 27, The dependency "@parse/node-apn" is pinned to a
non-existent "8.0.0" and will break installs; update the package.json entry for
"@parse/node-apn" to the published latest stable "7.1.0" (or, if 8.0.0 is
intentionally private/unreleased, replace the version with the correct
registry/git URL or document the private registry) and then verify src/APNS.js
usage of Provider, Notification and related properties still works against
7.1.0.
There was a problem hiding this comment.
@parse/node-apn 8.0.0 is published on npm and installs successfully. The only change in 8.0.0 is dropping Node 18 support — no API changes. All 93 tests pass with 100% coverage against 8.0.0.
There was a problem hiding this comment.
@mtrezza, apologies for the false positive — my earlier web search returned stale data that didn't reflect the published 8.0.0 release. Thank you for the confirmation that the package is live on npm, installs successfully, and all 93 tests pass with 100% coverage. The upgrade is valid and the review comment was incorrect.
@parse/node-apn 8.0.0 is published on npm. The only change is dropping Node 18 support — no API changes. All 93 tests pass with 100% coverage.
|
🎉 This change has been released in version 8.4.0 |
Closes #541
Changes
Breaking Changes
None applicable — this project's CI already runs Node.js 20/22/24 and does not support Node 18.
Code Changes Required
None — the upgrade is a drop-in replacement. All 93 tests pass with 100% coverage.
Summary by CodeRabbit