add pai helm chart to index ( fixes namespace issue )#1587
add pai helm chart to index ( fixes namespace issue )#1587nitisht merged 1 commit intoparseablehq:mainfrom
Conversation
WalkthroughAll chart metadata timestamps in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.OpenGrep is compatible with Semgrep configurations. Add an |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
index.yaml (1)
56-1544: Avoid rewriting historicalcreatedtimestamps for unchanged chart versions.Across Lines 56-1544,
createdwas rewritten for many existing versions without corresponding version/digest changes. This creates noisy diffs and distorts historical metadata. Prefer keepingcreatedstable for unchanged entries and only updatinggenerated(Line 1573) when regenerating the index.Also applies to: 1573-1573
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@index.yaml` around lines 56 - 1544, The index regeneration is overwriting per-chart "created" timestamps for entries whose version and digest did not change; update the index-generation logic to preserve the existing created value for any chart entry where the version and digest remain identical (compare chart entry keys "version" and "digest"), only set or update "created" for new or changed entries, and continue to update the top-level "generated" timestamp; search for the code that writes the index.yaml entries (the code that sets the "created" field) and modify it to load the existing index, merge entries by version+digest, and reuse the previous "created" when unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@index.yaml`:
- Around line 37-39: The index entry was only timestamped but not updated for a
new PAI chart release; publish a new pai chart artifact, increment the chart
version in the chart metadata (the "version" field for the pai package) and
regenerate the index so the "digest" for that pai entry is updated alongside the
"created" timestamp; ensure the new pai entry (with updated version and digest)
is added to index.yaml so consumers receive the namespace fix (verify the pai
package name, version and digest fields are consistent).
---
Nitpick comments:
In `@index.yaml`:
- Around line 56-1544: The index regeneration is overwriting per-chart "created"
timestamps for entries whose version and digest did not change; update the
index-generation logic to preserve the existing created value for any chart
entry where the version and digest remain identical (compare chart entry keys
"version" and "digest"), only set or update "created" for new or changed
entries, and continue to update the top-level "generated" timestamp; search for
the code that writes the index.yaml entries (the code that sets the "created"
field) and modify it to load the existing index, merge entries by
version+digest, and reuse the previous "created" when unchanged.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
index.yaml (1)
34-52:⚠️ Potential issue | 🔴 CriticalPAI chart digest in index.yaml does not match the actual package on the server.
The digest listed in index.yaml (line 39) is
1462c6ed8577bef3a5e125fe1a47a94a40ad3448d214faeb274576da9b14070b, but the package currently available athttps://charts.parseable.com/helm-releases/pai-0.1.0.tgzhas digest3db0d6325e38b837775a147ac5d49abcf73a8e877a90f2e8480f908b2d7c6862. This mismatch indicates the index is out of sync with the actual artifact. Either the index.yaml needs to be updated with the correct digest, or the chart package needs to be re-published to match the claimed digest. Without this alignment, users cannot reliably verify package integrity.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@index.yaml` around lines 34 - 52, The index.yaml entry for the chart named "pai" version 0.1.0 has a mismatched digest: update the digest field under the pai entry (digest: ...) to match the actual SHA256 of the hosted package at https://charts.parseable.com/helm-releases/pai-0.1.0.tgz (3db0d6325e38b837775a147ac5d49abcf73a8e877a90f2e8480f908b2d7c6862) or alternatively re-publish the pai-0.1.0.tgz so its SHA256 matches the existing digest; after correcting, regenerate/merge the Helm index (index.yaml) so the pai v0.1.0 entry and its digest are consistent with the package.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@index.yaml`:
- Around line 34-52: The index.yaml entry for the chart named "pai" version
0.1.0 has a mismatched digest: update the digest field under the pai entry
(digest: ...) to match the actual SHA256 of the hosted package at
https://charts.parseable.com/helm-releases/pai-0.1.0.tgz
(3db0d6325e38b837775a147ac5d49abcf73a8e877a90f2e8480f908b2d7c6862) or
alternatively re-publish the pai-0.1.0.tgz so its SHA256 matches the existing
digest; after correcting, regenerate/merge the Helm index (index.yaml) so the
pai v0.1.0 entry and its digest are consistent with the package.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f5dc56d1-9491-4046-96b4-ac78c13ac050
📒 Files selected for processing (2)
helm-releases/pai-0.1.0.tgzindex.yaml
2 participants
Fixes #XXXX.
Description
This PR has:
Summary by CodeRabbit