fix: show country code when city is unavailable in location display#20
Open
Boanerges1996 wants to merge 1 commit intopeermetrics:masterfrom
Open
fix: show country code when city is unavailable in location display#20Boanerges1996 wants to merge 1 commit intopeermetrics:masterfrom
Boanerges1996 wants to merge 1 commit intopeermetrics:masterfrom
Conversation
ipstack and AppEngine geo headers do not always include a city (e.g. for VPN, corporate proxy, or certain ISP IP ranges). Fall back to country_code alone so participants from those networks show a location rather than '-'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
participantsCard.vuerequired bothcityandcountry_codeto be non-null before rendering a location stringcountry_codealone whencityis nullBefore:
"Location: -"for any participant where city is unknownAfter:
"Location: DE"(or whichever country) when only country is known,"Location: Berlin, DE"when both are availableTest plan
City, CCformat is unchanged"Location: -"🤖 Generated with Claude Code