Skip to content

Include warnings for disable_functions and disable_classes#5429

Merged
iluuu1994 merged 2 commits intomasterfrom
disable_functions_classes-warning
Mar 19, 2026
Merged

Include warnings for disable_functions and disable_classes#5429
iluuu1994 merged 2 commits intomasterfrom
disable_functions_classes-warning

Conversation

@iluuu1994
Copy link
Member

Added warnings about security measures for shared hosting environments.

Added warnings about security measures for shared hosting environments.
@iluuu1994 iluuu1994 requested a review from Girgias March 18, 2026 22:43
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording LGTM.

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the warning on open_basedir states:

open_basedir is just an extra safety net, that is in no way comprehensive, and can therefore not be relied upon when security is needed.

Perhaps we can borrow the phrasing? Either way this makes sense to me.

@iluuu1994
Copy link
Member Author

I find this message a bit more explicit that the directive is entirely ineffective. But I don't object to using the other one.

@iluuu1994 iluuu1994 merged commit ef757b0 into master Mar 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants