Document each global ext/dom constant on its own row#5434
Open
kocsismate wants to merge 1 commit intophp:masterfrom
Open
Document each global ext/dom constant on its own row#5434kocsismate wants to merge 1 commit intophp:masterfrom
kocsismate wants to merge 1 commit intophp:masterfrom
Conversation
kocsismate
force-pushed
the
dom-const-links
branch
from
29d1429 to
06253f9
Compare
Member
|
I think from a DX point of view, the new one is worse. I believe they should be documented together for ease. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before these changes, the
gen_stub.php --verify-manualcommand used to fail with an exception due to ext/DOM constants being wrongly formatted: the old and new constant counterparts were documented in the same row (e.g.DOM_VALIDATION_ERR/Dom\VALIDATION_ERR) which format cannot be recognized by gen_stub.php. Instead, let's document each constant on its own row.Related to php/php-src#21484