Skip to content

Fix build#287

Merged
ondrejmirtes merged 4 commits intophpstan:2.0.xfrom
staabm:fixb
Mar 12, 2026
Merged

Fix build#287
ondrejmirtes merged 4 commits intophpstan:2.0.xfrom
staabm:fixb

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Mar 12, 2026

remove dead code, which errors since phpstan/phpstan-src#5209

before this PR

------ ----------------------------------------------------------------------- 
  Line   src/Rules/PHPUnit/AnnotationHelper.php                                 
 ------ ----------------------------------------------------------------------- 
  50     Call to function array_key_exists() with 'annotation' and array{0:     
         non-falsy-string, annotation: non-falsy-string, 1: non-falsy-string,   
         property: non-empty-string, 2: non-empty-string, whitespace: string,   
         3: string, value: string, ...} will always evaluate to true.           
         🪪  function.alreadyNarrowedType                                       
  50     Call to function array_key_exists() with 'whitespace' and array{0:     
         non-falsy-string, annotation: non-falsy-string, 1: non-falsy-string,   
         property: non-empty-string, 2: non-empty-string, whitespace: string,   
         3: string, value: string, ...} will always evaluate to true.           
         🪪  function.alreadyNarrowedType                                       
  50     Strict comparison using === between true and false will always         
         evaluate to false.                                                     
         🪪  identical.alwaysFalse                                              
         💡  Because the type is coming from a PHPDoc, you can turn off this    
         check by setting treatPhpDocTypesAsCertain: false in your phpstan.neo  
         n.                                                                     
  50     Strict comparison using === between true and false will always         
         evaluate to false.                                                     
         🪪  identical.alwaysFalse                                              
         💡  Because the type is coming from a PHPDoc, you can turn off this    
         check by setting treatPhpDocTypesAsCertain: false in your phpstan.neo  
         n.                                                                     
 ------ ----------------------------------------------------------------------- 

@ondrejmirtes
Copy link
Member

Should I release it alongside 2.1.41 or not necessary?

@ondrejmirtes ondrejmirtes merged commit e2c6207 into phpstan:2.0.x Mar 12, 2026
95 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the fixb branch March 12, 2026 14:05
@staabm
Copy link
Contributor Author

staabm commented Mar 12, 2026

Should I release it alongside 2.1.41 or not necessary?

I think its not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants