feat: Toggle whether redundancy show at Settings.#241
Open
yhx-12243 wants to merge 3 commits intopi-base:mainfrom
Open
feat: Toggle whether redundancy show at Settings.#241yhx-12243 wants to merge 3 commits intopi-base:mainfrom
yhx-12243 wants to merge 3 commits intopi-base:mainfrom
Conversation
yhx-12243
force-pushed
the
toggle-redundancy
branch
from
48fe0c7 to
08413b7
Compare
Contributor
|
Pi-base got a lot slower since the redundancy feature was added I feel like, so good to have this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason is that, computing redundancy for a space causes a large performance regression.
So I add the toggle button (default off) to make normal user viewing fluently.
cf. #236 (comment)