Skip to content

Fix ssl_verify parameter for IndexAsyncio #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
04cb wants to merge 1 commit into from
Closed

Fix ssl_verify parameter for IndexAsyncio #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pinecone/openapi_support/rest_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@ def __init__(self, configuration: Configuration) -> None:
"Additional dependencies are required to use Pinecone with asyncio. Include these extra dependencies in your project by installing `pinecone[asyncio]`."
) from None

if configuration.ssl_ca_cert is not None:
ca_certs = configuration.ssl_ca_cert
if configuration.verify_ssl:
if configuration.ssl_ca_cert is not None:
ca_certs = configuration.ssl_ca_cert
else:
ca_certs = certifi.where()

ssl_context = ssl.create_default_context(cafile=ca_certs)
conn = aiohttp.TCPConnector(ssl=ssl_context)
else:
ca_certs = certifi.where()

ssl_context = ssl.create_default_context(cafile=ca_certs)

conn = aiohttp.TCPConnector(verify_ssl=configuration.verify_ssl, ssl=ssl_context)
conn = aiohttp.TCPConnector(verify_ssl=False)
Copy link

@cursor cursor bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated verify_ssl used instead of ssl=False

Low Severity

The True branch uses the modern ssl parameter (ssl=ssl_context), but the False branch uses the deprecated verify_ssl=False parameter. Since the whole point of this PR is to stop mixing verify_ssl and ssl parameters (which are mutually exclusive since aiohttp 3.9.2), it would be more consistent and future-proof to use ssl=False instead of verify_ssl=False in the else branch. The verify_ssl parameter is deprecated in aiohttp in favor of ssl.

Fix in Cursor Fix in Web


if configuration.proxy:
self._session = aiohttp.ClientSession(connector=conn, proxy=configuration.proxy)
Expand Down