Skip to content

tidb-performance-tuning-config: remove pessimistic lock memory limit recommendations#22562

Open
dbsid wants to merge 1 commit intopingcap:masterfrom
dbsid:remove-pessimistic-txn-memory-limits-doc
Open

tidb-performance-tuning-config: remove pessimistic lock memory limit recommendations#22562
dbsid wants to merge 1 commit intopingcap:masterfrom
dbsid:remove-pessimistic-txn-memory-limits-doc

Conversation

@dbsid
Copy link
Contributor

@dbsid dbsid commented Mar 13, 2026

What's changed

  • remove in-memory-peer-size-limit and in-memory-instance-size-limit from the TiKV config example in tidb-performance-tuning-config.md
  • remove the corresponding recommendation row from the configuration table

Why

These settings were used as a targeted workaround for oversized Raft entries caused by accumulated in-memory pessimistic locks before leader transfer. They should not be documented as general performance tuning recommendations.

Testing

  • docs only

@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Mar 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the TiDB performance tuning documentation by removing specific TiKV configuration recommendations related to pessimistic lock memory limits. These settings were previously a targeted workaround for a specific issue and are not intended as general performance tuning advice, thus their removal clarifies and streamlines the guidance provided to users.

Highlights

  • Documentation Update: Removed in-memory-peer-size-limit and in-memory-instance-size-limit from the TiKV configuration example in tidb-performance-tuning-config.md.
  • Recommendation Removal: Eliminated the corresponding recommendation row for these settings from the configuration table, as they are no longer considered general performance tuning advice.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tidb-performance-tuning-config.md
    • Removed the [pessimistic-txn] section and its in-memory-peer-size-limit and in-memory-instance-size-limit configurations from the TiKV config example.
    • Deleted the table row describing in-memory-peer-size-limit and in-memory-instance-size-limit from the configuration recommendations.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Mar 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 13, 2026

Hi @dbsid. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the recommendation for in-memory-peer-size-limit and in-memory-instance-size-limit from the performance tuning guide. The rationale is that these settings are for a specific workaround, not for general performance tuning. The changes include removing the configuration from the TiKV example and the corresponding descriptive row from the table. The changes are consistent with the stated goal of the pull request.

@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 13, 2026
@hfxsd hfxsd self-assigned this Mar 13, 2026
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 13, 2026

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants