tidb-performance-tuning-config: remove pessimistic lock memory limit recommendations#22562
tidb-performance-tuning-config: remove pessimistic lock memory limit recommendations#22562dbsid wants to merge 1 commit intopingcap:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the TiDB performance tuning documentation by removing specific TiKV configuration recommendations related to pessimistic lock memory limits. These settings were previously a targeted workaround for a specific issue and are not intended as general performance tuning advice, thus their removal clarifies and streamlines the guidance provided to users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @dbsid. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request removes the recommendation for in-memory-peer-size-limit and in-memory-instance-size-limit from the performance tuning guide. The rationale is that these settings are for a specific workaround, not for general performance tuning. The changes include removing the configuration from the TiKV example and the corresponding descriptive row from the table. The changes are consistent with the stated goal of the pull request.
|
/ok-to-test |
What's changed
in-memory-peer-size-limitandin-memory-instance-size-limitfrom the TiKV config example intidb-performance-tuning-config.mdWhy
These settings were used as a targeted workaround for oversized Raft entries caused by accumulated in-memory pessimistic locks before leader transfer. They should not be documented as general performance tuning recommendations.
Testing