tidb: add singleton_sketch for RowSampleCollector#407
Open
0xPoe wants to merge 1 commit intopingcap:masterfrom
Open
tidb: add singleton_sketch for RowSampleCollector#4070xPoe wants to merge 1 commit intopingcap:masterfrom
0xPoe wants to merge 1 commit intopingcap:masterfrom
Conversation
0xPoe
commented
Mar 31, 2026
Member
Author
0xPoe
left a comment
0xPoe
left a comment
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback)
-
Code compiles successfully
-
Unit tests added
-
No AI-generated elegant nonsense in PR.
-
Bazel files updated
-
Comments added where necessary
-
PR title and description updated
-
Documentation PR created (or confirmed not needed)
-
PR size is reasonable
0xPoe
force-pushed
the
poe-patch-f1-2026-03-31
branch
2 times, most recently
from
a7025da to
c976021
Compare
winoros
previously approved these changes
Mar 31, 2026
Member
Author
|
/hold |
0xPoe
changed the title
0xPoe
changed the title
Member
Author
|
/unhold |
0xPoe
force-pushed
the
poe-patch-f1-2026-03-31
branch
from
c976021 to
10f71a5
Compare
Signed-off-by: 0xPoe <techregister@pm.me>
0xPoe
force-pushed
the
poe-patch-f1-2026-03-31
branch
from
10f71a5 to
3def234
Compare
0xPoe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref pingcap/tidb#67449
Problem Summary:
What is changed and how it works?
What's Changed:
Added the singleton sketch to help us collect the singleton values from each TiKV.
How it Works:
Some preparatory work.
Related changes
pingcap/docs/pingcap/docs-cn: