cluster: PDInstance PostRestart to check for nil updcfg#2697
Open
sgykfjsm wants to merge 1 commit intopingcap:masterfrom
Open
cluster: PDInstance PostRestart to check for nil updcfg#2697sgykfjsm wants to merge 1 commit intopingcap:masterfrom
sgykfjsm wants to merge 1 commit intopingcap:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2697 +/- ##
==========================================
- Coverage 42.36% 42.35% -0.01%
==========================================
Files 424 424
Lines 47018 47018
==========================================
- Hits 19917 19911 -6
- Misses 24412 24418 +6
Partials 2689 2689 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #2696
What is changed and how it works?
Add a nil check to prevent a dereference of
updcfgduring the standard cluster startup process.Check List
Tests
Code changes
Side effects
Related changes
Release notes: