Skip to content

add OJT Control Panel for OJS 3.2.1.x and 3.3.x.x#307

Open
rahmanramsi wants to merge 2 commits intopkp:mainfrom
openjournalteam:ojtControlPanel
Open

add OJT Control Panel for OJS 3.2.1.x and 3.3.x.x#307
rahmanramsi wants to merge 2 commits intopkp:mainfrom
openjournalteam:ojtControlPanel

Conversation

@rahmanramsi
Copy link

Add OJT Control Panel Plugin for OJS 3.2.x and 3.3.x

@asmecher
Copy link
Member

My apologies for letting this PR go so long without a response!

I passed some feedback via email, but will copy it here:

The challenge with the OJT Control Panel plugin is what I mentioned during the Tuesday session; it allows for the installation of arbitrary code, so we can't fully review it for safety as we do with all plugins added to the Plugin Gallery.

I'm nearly finished writing up my proposal to allow for additional XML to be used for the plugin gallery. If we can get this merged, it'll give you a way forward. You would need to ask users to add a new plugin gallery URL to the configuration file, but then they'll be able to install the plugin (and any others you add to your XML) using the Plugin Gallery from there.

Essentially, our current policy is that we must be able to review the code that is introduced via the Plugin Gallery. Plugins should not be able to execute more code from 3rd party sources not distributed with the plugin, as we can't review those. I hope that #12468 provides a suitable way forward!

@irsyad33
Copy link

Hi Alec,

Thank you for your detailed explanation and for reviewing our PR.

We understand your concerns regarding current Plugin Gallery policy.

We appreciate your effort on the additional XML proposal. We will wait for further updates from your side regarding this. If your proposal is approved in the future, please feel free to let us know so we can consider the next steps or other possible approaches.

Thank you again for your time and feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants