Implement RFC 7807 error handling with compatibility mode (#165)#2004
Implement RFC 7807 error handling with compatibility mode (#165)#2004
Conversation
|
@avoinea thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
davisagli
left a comment
There was a problem hiding this comment.
Oh, hmm. I hadn't even noticed Timo's suggestion in #165 to follow RFC 7807 -- and that was 7 years ago. I like the idea of following a standard, but I need to study the details before I give more feedback.
Initial reactions:
- RFC 7807 says at the top that it is obsoleted by RFC 9457, so we should take a look at that one instead.
- Changes to the serialization of exceptions should be done in https://github.com/plone/plone.rest/blob/main/src/plone/rest/errors.py, not in the Service class here.
|
@silviupanaite Please see @davisagli suggestions. |
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #
📚 Documentation preview 📚: https://plonerestapi--2004.org.readthedocs.build/