Skip to content

Implement RFC 7807 error handling with compatibility mode (#165)#2004

Open
avoinea wants to merge 2 commits intomainfrom
issue-165-rfc7807-error-handling
Open

Implement RFC 7807 error handling with compatibility mode (#165)#2004
avoinea wants to merge 2 commits intomainfrom
issue-165-rfc7807-error-handling

Conversation

@avoinea
Copy link
Copy Markdown
Member

@avoinea avoinea commented Mar 20, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


📚 Documentation preview 📚: https://plonerestapi--2004.org.readthedocs.build/

@avoinea avoinea requested a review from davisagli March 20, 2026 10:51
@mister-roboto
Copy link
Copy Markdown

@avoinea thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community bot commented Mar 20, 2026

Documentation build overview

📚 plone.restapi | 🛠️ Build #31895071 | 📁 Comparing 59cd5c8 against latest (abebc6b)


🔍 Preview build

Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
File Status
http-status-codes.html 📝 modified
index.html 📝 modified

Copy link
Copy Markdown
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, hmm. I hadn't even noticed Timo's suggestion in #165 to follow RFC 7807 -- and that was 7 years ago. I like the idea of following a standard, but I need to study the details before I give more feedback.

Initial reactions:

  1. RFC 7807 says at the top that it is obsoleted by RFC 9457, so we should take a look at that one instead.
  2. Changes to the serialization of exceptions should be done in https://github.com/plone/plone.rest/blob/main/src/plone/rest/errors.py, not in the Service class here.

@avoinea
Copy link
Copy Markdown
Member Author

avoinea commented Mar 20, 2026

@silviupanaite Please see @davisagli suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants