Conversation
| .extImpId(extImp.getExtImpId()) | ||
| .build())); | ||
|
|
||
| final String gpid = ObjectUtil.getIfNotNull(imp.getExt().get("gpid"), JsonNode::textValue); |
There was a problem hiding this comment.
Use .at() to simplify. This will return MissingNode instead of null in case of absence, which .asText() will return empty string.
|
This PR relies on #4316 |
|
Hi, @Lightwood13 thanks for the work on this feature. We’re following it closely because it would be very useful for us at Freestar. Besides the cookie family duplicates, Do you have a rough sense of the remaining blockers or timeline for merge? Happy to help with testing or validation from our side if that would be useful. |
Hello. Thanks for offering help. This PR requires a breaking change to cookie syncing logic. PBS-Go did a silent change quite a bit ago which fixed the cookie family name usage for cookie syncs. Because that change is potentially breaking, we plan to roll it into 4.0. Our team is working on the 4.0 scope, and we plan to have everything released in Q2. If we'll need help with anything, we'll contact you, though. So thanks for offering help. |
6 participants
🔧 Type of changes
✨ What's the context?
#4294