fix: replace shell syntax in run() calls with safe array args#308
Open
TerminalGravity wants to merge 2 commits intomainfrom
Open
fix: replace shell syntax in run() calls with safe array args#308TerminalGravity wants to merge 2 commits intomainfrom
TerminalGravity wants to merge 2 commits intomainfrom
Conversation
The interactive setup wizard (npx preflight-dev init) was buried in a footnote under Option C, despite being the most user-friendly onboarding path. Moved it to Option A with a clear description of what it does. Renumbered remaining options accordingly.
run() uses execFileSync without a shell, so shell operators like 2>/dev/null, pipes, &&, and redirects were passed as literal args, causing silent failures across 8 tool files. Changes: - Add exec(), countLines(), countBytes(), headLines() helpers to git.ts - Convert all run() calls to use array args for git commands - Replace shell pipelines (grep, wc, head, tail) with Node.js equivalents - Fix checkpoint.ts to use separate run() calls instead of && chaining - Replace 'command -v' with 'which' via exec() helper Fixes #302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302
run()usesexecFileSync('git', ...)without a shell, but 8 tool files were passing strings with shell operators (2>/dev/null, pipes,&&, redirects) that got split on whitespace and passed as literal git args — causing silent failures.Changes
exec(),countLines(),countBytes(),headLines()helpers togit.tsrun()calls to use array args for git commandsgrep,wc,head,tail) with Node.js equivalentscheckpoint.tsto use separaterun()calls instead of&&chainingcommand -vwithwhichviaexec()helperAffected files (all 8 from the issue)
token-audit.ts✅enrich-agent-task.ts✅clarify-intent.ts✅audit-workspace.ts✅sharpen-followup.ts✅session-handoff.ts✅sequence-tasks.ts✅checkpoint.ts✅All tests pass,
tsc --noEmitclean.