(opt) cache managed cluster DiscoveryClient and RESTMapper#1644
Merged
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom Mar 15, 2026
Merged
(opt) cache managed cluster DiscoveryClient and RESTMapper#1644gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
gianlucam76 merged 1 commit intoprojectsveltos:mainfrom
Conversation
gianlucam76
force-pushed
the
restmapper
branch
2 times, most recently
from
a56a471 to
89d8136
Compare
Instead of creating a new DiscoveryClient and RESTMapper every time a resource is deployed, do it once and re-use it. When a "Kind Not Found" (NoMatchError) occurs, code performs a targeted invalidation. We explicitly call Invalidate() on the DiscoveryClient and Reset() on the RESTMapper to force a fresh fetch from the remote cluster, ensuring newly created CRDs are discovered without requiring a controller restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating a new DiscoveryClient and RESTMapper every time a resource is deployed, do it once and re-use it.
When a "Kind Not Found" (NoMatchError) occurs, code performs a targeted invalidation. We explicitly call Invalidate() on the DiscoveryClient and Reset() on the RESTMapper to force a fresh fetch from the remote cluster, ensuring newly created CRDs are discovered without requiring a controller restart.