SECURITY, PERFORMANCE & READABILITY!#218
Open
SpinnySpiwal wants to merge 2 commits intoprometheus-lua:masterfrom
Open
SECURITY, PERFORMANCE & READABILITY!#218SpinnySpiwal wants to merge 2 commits intoprometheus-lua:masterfrom
SpinnySpiwal wants to merge 2 commits intoprometheus-lua:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MEGA UPDATE brings 1 enhancement and 1 security improvement to EncryptStrings, increasing performance by 1.1x.
bug 1:
input:
("").char -- function 0x......output:
"".char -- blah blah syntax errorbug 2:
input:
(0).char -- error, but can be isolated in pcall to intentionally prevent usage of Prometheus for minification or prettification of the script.output:
0.char -- blah blah syntax error!!!Both bugs have their own according test, found in
syntax.lua.Bug 3 is more complex. It's to do with Multi-Return and a specific test. This issue was also fixed by adding a simple if statement and a new Multi-Return Test.
Also optimised comparison operations code and arithmetic-operation code in the unparser too!
Added consistency to the top of every file by fixing the missing
Also improved the formatting in presets.lua to make it easier to read, less comment crowded & more self explanatory.
fixed (all?) random newlines that looked like this in files:
Yes, just empty lines with whitespaces. Gone!
Fixed ProifyLocals variable name changed to ProxifyLocals in ProxifyLocals.lua. Fixed EncryptStrings.lua 'CreateEncrypionService' renamed to 'CreateEncryptionService' (spell correction)
I understand it appears that every file under the sun has been modified, so this might take a while to review.
Why did I create these 2 updates? Well, mainly to push-back on Prometheus deobfuscators. But also because I'm contributing or FOSS, which isn't something I do often.