Skip to content

Prepare for OTP29#327

Closed
NelsonVides wants to merge 1 commit intoproper-testing:masterfrom
NelsonVides:otp_29
Closed

Prepare for OTP29#327
NelsonVides wants to merge 1 commit intoproper-testing:masterfrom
NelsonVides:otp_29

Conversation

@NelsonVides
Copy link

Mostly issues around deprecating catch expressions. Also a warning around the is_record bif and deprecated export from subexpression warning (the new filtermap).

Mostly issues around deprecating `catch` expressions. Also a warning
around the is_record bif and deprecated export from subexpression
warning (the new filtermap).
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.39%. Comparing base (f511d29) to head (88ea3fb).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/proper_statem.erl 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   85.27%   85.39%   +0.11%     
==========================================
  Files          14       14              
  Lines        4590     4600      +10     
==========================================
+ Hits         3914     3928      +14     
+ Misses        676      672       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NelsonVides
Copy link
Author

Actually I just noticed that #324 does pretty much the same and it's actually kinda cleaner, I like that one better 😄
Looking forward for a new OTP29-ready release 🥹

There's also the option to add latest to the CI matrix, in case we'd want to verify this in CI as well.

@kostis
Copy link
Collaborator

kostis commented Mar 23, 2026

Thanks for your PR and your comment. I agree with you that #324 is a cleaner PR, so we'll probably go with that.

There's also the option to add latest to the CI matrix, in case we'd want to verify this in CI as well.

Yes, we should definitely verify this in the CI - that's the point in having one. However, AFAIK Erlang/OTP 29 is not yet released. Does latest also consider pre-releases as latest candidates?

@NelsonVides
Copy link
Author

Yes, latest includes release candidates: https://github.com/erlef/setup-beam?tab=readme-ov-file#latest-versions 🙂

I can't push to the other PR, but maybe we want to add that configuration to the CI matrix and get the other one merged? I'm closing this in the meantime in favour of #324 💪🏽

@NelsonVides NelsonVides deleted the otp_29 branch March 23, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants