Conversation
Mostly issues around deprecating `catch` expressions. Also a warning around the is_record bif and deprecated export from subexpression warning (the new filtermap).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 85.27% 85.39% +0.11%
==========================================
Files 14 14
Lines 4590 4600 +10
==========================================
+ Hits 3914 3928 +14
+ Misses 676 672 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Actually I just noticed that #324 does pretty much the same and it's actually kinda cleaner, I like that one better 😄 There's also the option to add |
|
Thanks for your PR and your comment. I agree with you that #324 is a cleaner PR, so we'll probably go with that.
Yes, we should definitely verify this in the CI - that's the point in having one. However, AFAIK Erlang/OTP 29 is not yet released. Does |
|
Yes, I can't push to the other PR, but maybe we want to add that configuration to the CI matrix and get the other one merged? I'm closing this in the meantime in favour of #324 💪🏽 |
Mostly issues around deprecating
catchexpressions. Also a warning around the is_record bif and deprecated export from subexpression warning (the new filtermap).