Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves
This PR fixes workflow export bootstrapping for upscale workflows that reference
UpscaleModelLoaderor other node classes that are not loaded yet in the current runtime.Before this change, the exporter decided whether to initialize extra/custom nodes before reading the workflow, which meant it could miss required node mappings and generate incorrect bootstrap code for workflows that depended on those nodes.
What changed
COMFYUI_PATHwhen locating ComfyUI so installs outside the repo still resolve imports consistentlysys.pathduring setupUpscaleModelLoaderdirectly instead of falling back toNODE_CLASS_MAPPINGS[...]()Documentation updates included in this PR
ComfyUI/custom_nodesor running the repo out of tree withCOMFYUI_PATHSave As Scriptuv-based setup and command examplesResult
Upscale workflows now export with the expected loader bootstrap, out-of-tree ComfyUI installs are discovered more reliably when
COMFYUI_PATHis set, and the README now reflects the current setup and usage flow more clearly.