gh-145856: Fix plistlib.dumps() skipkeys behavior with mixed key types#145867
Closed
VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
Closed
gh-145856: Fix plistlib.dumps() skipkeys behavior with mixed key types#145867VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
VanshAgarwal24036 wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Contributor
Author
|
@stefanzetzsche Sorry, I opened this PR before noticing ZeroIntensity’s comment about giving the issue author a chance to submit a PR first. My intention was just to help resolve the issue. If the author would like to work on it themselves, I’m happy to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
skipkeys=True,plistlib.dumps()attempted to sort dictionary keys before filtering non-string keys,causing a
TypeErrorfor mixed key types.This change filters non-string keys first and then sorts the remaining items.
plistlib.dumps()raisesTypeErrorwhenskipkeys=Trueand dict has mixed key types #145856