You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The wheel path detection logic changed, but I think that's ok. Would be nice if xcookie could keep the comments in the CI yaml. I was having issues getting ruamel.yaml doing that. I may manually update if I can solve the CI issues.
Given that the wheelhouse and a wheel of the matching version and architecture exist, IDK why this would happen... can't seem to reproduce this behavior on local with (vanilla) pipeither.
Unfortunately the equivalent uv command in the passing pipeline didn't produce enough output to indicate whence it pulled the line_profiler wheel, but I have to guess the wheelhouse and not PyPI judging from how the tests did pass.
The 3.9 [...] with tests-strict,runtime-strict jobs additionally fail the ref-counting in these four tests in tests/test_line_profiler.py:
test_double_decoration
test_function_decorator
test_async_gen_decorator[...]
The cause is how the tests-strict extra pins coverage to 6.5 (see requirements/tests.txt); in my testing, anything below 7.3 consistently breaks these tests between Python 3.9 and 3.11. This bug seems consistent with what is described in CTracer fails to deallocate bound methods references coveragepy/coveragepy#1283 (reported on Python 3.8, coverage 6.1), where a couple refs are leaked when coverage is used; this however begs the question of why this adverse interaction didn't manifest when we had equivalent setups on Python 3.8? (Same discrepancy on local – 6.5 works with 3.8 but not any newer Pythons.)
Looking at the diffs, not only is the ARM-Linux stuff gone (regressing FIX: building Linux-ARM64 wheels #402), one of the test jobs on regular Ubuntu (3.13 on ubuntu-latest, arch=auto with tests) is also caught in the crossfire:
As described in FIX: building on Windows-ARM64 #391, we skipped these Python versions because we can't test them on GitHub's windows-11-arm runners. As far as I can tell, this constraint is still true:
Not to mention: even if the intent was to specifically un-skip building 3.9 wheel for ARM-Windows, this form still causes issues as braces without multiple options therein isn't correctly parsed by cibuildwheel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping CI versions with xcookie to see if that avoids recent CI errors. This will drop 3.8 support, which is overdue anyway.
I think we may need to re-add the arm entries:
The wheel path detection logic changed, but I think that's ok. Would be nice if xcookie could keep the comments in the CI yaml. I was having issues getting ruamel.yaml doing that. I may manually update if I can solve the CI issues.