camera_nhx: improve NHX validation portability and robustness#338
Open
smuppand wants to merge 3 commits intoqualcomm-linux:mainfrom
Open
camera_nhx: improve NHX validation portability and robustness#338smuppand wants to merge 3 commits intoqualcomm-linux:mainfrom
smuppand wants to merge 3 commits intoqualcomm-linux:mainfrom
Conversation
Prefer GNU stat output first, then fall back to BSD stat and wc -c. This avoids false zero-byte results on target images where the earlier ordering could return an incorrect numeric value before reaching a safe fallback. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Update camera helpers to better support NHX validation across targets. Changes include: - board-aware camera module selection from DT data - generic CAMERA_ICP firmware discovery under /lib/firmware/qcom - package detection for both opkg and dnf/rpm based images - cam-server logging helpers for status and stdout capture - NHX dump size helper built on shared file size detection Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Rework the Camera_NHX runner to use the updated shared helpers and make the validation flow more robust. Changes include: - use board-aware camera module selection - use generic CAMERA_ICP firmware lookup - support rpm/dnf based images through shared package detection - stop/start cam-server around nhx.sh and capture status/stdout logs - keep pre-NHX CAMX dmesg checks warn-only - reuse shared dump size handling during dump validation Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Camera_NHX validation flow by moving reusable logic into shared helpers and making the runner work more reliably across supported Qualcomm targets and image variants.
Why:
Overall, this keeps the NHX runner focused on orchestration while pushing reusable camera and utility logic into common helper layers.