userspace-resource-manager: Modify test runner for URM#352
userspace-resource-manager: Modify test runner for URM#352kartnema wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
Signed-off-by: Kartik Nema <kartnema@qti.qualcomm.com>
kartnema
changed the title
| # base config requirement: accept common OR tests; skip only if BOTH missing | ||
| if suite_requires_base_cfgs "$name"; then | ||
| if [ $COMMON_OK -eq 0 ] && [ $CUSTOM_OK -eq 0 ]; then | ||
| if [ $COMMON_CONFIGS_OK -eq 0 ] && [ $TEST_CONFIGS_OK -eq 0 ] && [ $TEST_NODES_OK -eq 0 ]; then |
There was a problem hiding this comment.
I think this changes the gating semantics in a risky way. tests/nodes looks like a required input for the URM suites, but with this condition the suite will still run when configs are present and tests/nodes is missing. Should the nodes check remain a separate per-suite skip, instead of being folded into the “all three missing” condition?
There was a problem hiding this comment.
For the update test suites, both tests/nodes and tests/configs are required input, in addition to common configs.
The goal is since, running test case with tests/nodes present but tests/configs (or the other way around) does not make sense, hence a more exhaustive check needs to be added to see if all 3 requirements are satisfied. I'll make the code level checks, and change the comments as appropriate.
| if suite_requires_base_cfgs "$name"; then | ||
| if [ $COMMON_OK -eq 0 ] && [ $CUSTOM_OK -eq 0 ]; then | ||
| if [ $COMMON_CONFIGS_OK -eq 0 ] && [ $TEST_CONFIGS_OK -eq 0 ] && [ $TEST_NODES_OK -eq 0 ]; then | ||
| log_skip "[CFG] Base configs missing (common/ AND custom/) — skipping $name" |
There was a problem hiding this comment.
This still says custom/, but the new path is tests/configs. Please update the message so runtime logs match the new layout.
2 participants
Update the existing test runner for resource-tuner: