Skip to content

hexagon: accept Qwen3.5 ROPE and RMS_NORM ops in HTP backend #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdhinaka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hexagon: accept Qwen3.5 ROPE and RMS_NORM ops in HTP backend #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ggml/src/ggml-hexagon/ggml-hexagon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1962,7 +1962,7 @@ static bool ggml_hexagon_supported_unary(const struct ggml_hexagon_session * ses
}

// TODO: add support for non-contigiuos tensors
if (!ggml_is_contiguous(src0) || !ggml_is_contiguous(dst)) {
if (!ggml_is_contiguous(dst)) {
return false;
}

Expand Down Expand Up @@ -2133,7 +2133,7 @@ static bool ggml_hexagon_supported_rope(const struct ggml_hexagon_session * sess

int mode = op_params[2];

if ((mode & GGML_ROPE_TYPE_MROPE) || (mode & GGML_ROPE_TYPE_VISION)) {
if ((mode & GGML_ROPE_TYPE_MROPE) == GGML_ROPE_TYPE_MROPE) {
return false;
}
if (mode & 1) {
Expand Down