Conversation
haseebsyed12
approved these changes
Mar 31, 2026
skrobul
reviewed
Mar 31, 2026
Collaborator
skrobul
left a comment
There was a problem hiding this comment.
This is very repeatable and may be difficult to maintain. What do you think of DRYing it out and having a helper like:
{{- define "understack.appLabelsBlock" -}}
{{- with .Values.appLabels }}
labels:
{{- toYaml . | nindent 2 }}
{{- end -}}
{{- end }}and then in each of the apps just call:
{{- include "understack.appLabelsBlock" $ | nindent 2 }}Add the ability to apply common labels to all of the Applications to give the ability to search and sort ArgoCD on the labels.
Contributor
Author
Good point. I've done this. |
skrobul
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to apply common labels to all of the Applications to
give the ability to search and sort ArgoCD on the labels.