Skip to content

feat(argocd-understack): add common labels to the Applications#1898

Merged
cardoe merged 1 commit intomainfrom
applabels
Mar 31, 2026
Merged

feat(argocd-understack): add common labels to the Applications#1898
cardoe merged 1 commit intomainfrom
applabels

Conversation

@cardoe
Copy link
Copy Markdown
Contributor

@cardoe cardoe commented Mar 31, 2026

Add the ability to apply common labels to all of the Applications to
give the ability to search and sort ArgoCD on the labels.

@cardoe cardoe requested a review from a team March 31, 2026 16:25
Copy link
Copy Markdown
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very repeatable and may be difficult to maintain. What do you think of DRYing it out and having a helper like:

{{- define "understack.appLabelsBlock" -}}
{{- with .Values.appLabels }}
labels:
{{- toYaml . | nindent 2 }}
{{- end -}}
{{- end }}

and then in each of the apps just call:

{{- include "understack.appLabelsBlock" $ | nindent 2 }}

Add the ability to apply common labels to all of the Applications to
give the ability to search and sort ArgoCD on the labels.
@cardoe
Copy link
Copy Markdown
Contributor Author

cardoe commented Mar 31, 2026

This is very repeatable and may be difficult to maintain. What do you think of DRYing it out and having a helper like:

{{- define "understack.appLabelsBlock" -}}
{{- with .Values.appLabels }}
labels:
{{- toYaml . | nindent 2 }}
{{- end -}}
{{- end }}

and then in each of the apps just call:

{{- include "understack.appLabelsBlock" $ | nindent 2 }}

Good point. I've done this.

@cardoe cardoe added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit bfb2165 Mar 31, 2026
20 checks passed
@cardoe cardoe deleted the applabels branch March 31, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants