Fixing StackOverFlow in MDX Component#146
Merged
orama254 merged 4 commits intoreactjs:mainfrom Mar 12, 2026
Merged
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing the live application at sw-react-dev.vercel.app/learn, I noticed significant performance issues:
Imagecomponent errors due to missing requiredwidthandheightattributes/learn/thinking-in-reactand/learn/tutorial-tic-tac-toe—were experiencing excessive load timesSolution
widthandheightattributes onImagecomponents inHomeContent.jsto comply with Next.js requirements but still the issue persisted.<img>tags while our implementation used Next.js optimizedImagecomponents across MDX content.These changes should also ensure a successful build and deployment process moving forward.