Always pass dry-run parameter

[justin-cechmanek]

dry-run is a boolean, so was not being added to params[] when set to False. The server defaulted to True in all cases.

---

Note

Medium Risk
Changes the forget_long_term_memories request semantics so dry_run=False results in real deletions instead of silently using the server default (True); this could unexpectedly delete data for callers who previously relied on the buggy behavior. Otherwise the change is small and covered by updated unit tests.

Overview
Fixes forget_long_term_memories to always include the boolean dry_run query param (including when False), avoiding the server’s default of dry_run=True from being applied unintentionally.

Updates tests to assert the exact POST /v1/long-term-memory/forget call parameters for basic, dry-run, and filtered forget requests.

^{Written by Cursor Bugbot for commit 545eeb2. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

Fixes a client/server behavior mismatch where dry_run=False was previously omitted from query params, causing the server to apply its default (True) and unintentionally run in dry-run mode.

Changes:

• Always include the dry_run query parameter when calling the long-term memory “forget” endpoint.
• Adds an inline comment explaining why dry_run must be passed explicitly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Fix correctly addresses the bug where dry_run=False was not being sent to the server, causing the server default to be applied. Good catch on this boolean parameter handling issue.

[jit-ci]

🛡️ Jit Security Scan Results

✅ No security findings were detected in this PR

---

^{Security scan by Jit}

[abrookins]

Good catch! Can you add a test?

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[abrookins]

LGTM - thanks for jumping on this! 👍