Skip to content

fix(upload): correct on_drop_rejected args spec #6342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BABTUNA wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −4
Open

fix(upload): correct on_drop_rejected args spec #6342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
327d7d6
Fix upload on_drop_rejected args spec
BABTUNA Apr 19, 2026
c6ff44b
test(upload): parametrize on_drop_rejected spec check over GhostUploa…
FarhanAliRaza Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/reflex-components-core/src/reflex_components_core/core/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ def get_upload_url(file_path: str | Var[str]) -> Var[str]:
_on_drop_spec,
passthrough_event_spec(UploadChunkIterator),
)
_on_drop_rejected_spec = passthrough_event_spec(list[dict[str, Any]])
_UPLOAD_FILES_CLIENT_HANDLER = "uploadFiles"


Expand Down Expand Up @@ -220,7 +221,7 @@ class GhostUpload(Fragment):
# Fired when files are dropped.
on_drop: EventHandler[_on_drop_args_spec]

on_drop_rejected: EventHandler[_on_drop_spec] = field(
on_drop_rejected: EventHandler[_on_drop_rejected_spec] = field(
doc="Fired when dropped files do not meet the specified criteria."
)

Expand Down Expand Up @@ -264,7 +265,7 @@ class Upload(MemoizationLeaf):
# Fired when files are dropped.
on_drop: EventHandler[_on_drop_args_spec]

on_drop_rejected: EventHandler[_on_drop_spec] = field(
on_drop_rejected: EventHandler[_on_drop_rejected_spec] = field(
doc="Fired when dropped files do not meet the specified criteria."
)

Expand Down
2 changes: 1 addition & 1 deletion pyi_hashes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"packages/reflex-components-core/src/reflex_components_core/core/helmet.pyi": "7fd81a99bde5b0ff94bb52523597fd5c",
"packages/reflex-components-core/src/reflex_components_core/core/html.pyi": "753d6ae315369530dad450ed643f5be6",
"packages/reflex-components-core/src/reflex_components_core/core/sticky.pyi": "ba60a7d9cba75b27a1133bd63a9fbd59",
"packages/reflex-components-core/src/reflex_components_core/core/upload.pyi": "17775edb94cc804686ae4cd873584810",
"packages/reflex-components-core/src/reflex_components_core/core/upload.pyi": "48bccd1cf1cedaf24503e7dbd2c0b02b",
"packages/reflex-components-core/src/reflex_components_core/core/window_events.pyi": "cab827931770be082cd1598a9908abbc",
"packages/reflex-components-core/src/reflex_components_core/datadisplay/__init__.pyi": "c96fed4da42a13576d64f84e3c7cb25c",
"packages/reflex-components-core/src/reflex_components_core/el/__init__.pyi": "f09129ddefb57ab4c7769c86dc9a3153",
Expand Down
11 changes: 10 additions & 1 deletion tests/units/components/core/test_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
from typing import Any, cast

import pytest
from reflex_base.event import EventChain, EventHandler, EventSpec
from reflex_base.event import EventChain, EventHandler, EventSpec, parse_args_spec
from reflex_base.vars.base import LiteralVar, Var
from reflex_components_core.core.upload import (
GhostUpload,
StyledUpload,
Upload,
UploadNamespace,
Expand Down Expand Up @@ -76,6 +77,14 @@ def test__on_drop_spec():
assert isinstance(_on_drop_spec(LiteralVar.create([])), tuple)


@pytest.mark.parametrize("component", [Upload, GhostUpload])
def test_on_drop_rejected_uses_file_rejection_payload_spec(component):
rejected_spec = component.get_event_triggers()["on_drop_rejected"]
placeholders, _ = parse_args_spec(rejected_spec)

assert placeholders[0]._var_type == list[dict[str, Any]]


def test_upload_files_chunk_requires_background():
with pytest.raises(TypeError) as err:
event.resolve_upload_chunk_handler_param(
Expand Down
Loading