Conversation
40b185e to
a1a9134
Compare
I do think it makes sense to use C.UTF-8 as it does not depend on OS locale settings and hence is deterministic across Postgres instances. With en_US.UTF-8 any updates to glibc or ICU could affect the existing sorting order. If it is really needed, it can still be defined on column level.
sislr
commented
Mar 25, 2026
| # replace rubocop-rails-omakase with renuocop | ||
| # configure the database collation | ||
| insert_into_file "config/database.yml", after: "adapter: postgresql\n" do | ||
| " template: template0\n collation: C.UTF-8\n" |
Member
Author
There was a problem hiding this comment.
template0 is required as it fails otherwise with:
PG::InvalidParameterValue: ERROR: new collation (C.UTF-8) is incompatible with the collation of the template database (C) (PG::InvalidParameterValue)
HINT: Use the same collation as in the template database, or use template0 as template.
sislr
commented
Mar 25, 2026
Member
Author
There was a problem hiding this comment.
these were outdated anyways
coorasse
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follows https://github.com/renuo/renuo-cli/pull/287
Tested locally
generated
config/database.yml:DB setup: