App-792: standardize canvas widget card padding, title typography, and borders#9014
Open
App-792: standardize canvas widget card padding, title typography, and borders#9014
Conversation
Di7design
changed the title
Di7design
changed the title
ericpgreen2
requested review from
djbarnwal
and removed request for
ericpgreen2
Contributor
|
Tagging @djbarnwal for the code review, since he's the main maintainer for these components |
Member
|
There are still some inconsistencies with respect to padding. For example - The KPI padding looks too excessive. Table padding make it look out of place, there is no border line on top and left edge Excessive padding in leaderboards The padding looks inconsistent when the component has a title vs without one. |
Di7design
force-pushed
the
di-rill/standardize-canvas-widget-padding
branch
from
983cd2e to
ed30b45
Compare
…ally - CanvasComponent: card owns all padding (p-4), border radius rounded-[6px], border+shadow replaces outline - ComponentHeader: title 16px semibold leading-none, no self-padding (card provides it) - CanvasChart/LeaderboardDisplay/CanvasPivotDisplay: uniform size-full flex-col gap-y-4 layout - CanvasPivotRenderer: remove self-padding (card provides it) - VegaLiteRenderer: remove extra px-2 on canvas dashboards - vega-config: set padding:0 for canvas dashboards to eliminate Vega's default internal padding Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ComponentHeader: add pt-2 pb-1, gap-y-1 between title/description, fix leading-tight on title - KPIGrid: wrap in gap-y-4 container, reduce cell padding to p-3, remove border-overlay - LeaderboardDisplay: remove border-overlay - Markdown: change px-2 to p-4 to match other widgets Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Di7design
force-pushed
the
di-rill/standardize-canvas-widget-padding
branch
from
ed30b45 to
d641e90
Compare
- Add isCanvasDashboard parameter to getRillTheme in vega-config.ts - Remove unused canvasDashboard export from VegaLiteRenderer.svelte - Fix prettier formatting in LeaderboardDisplay.svelte Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
I've changed the paddings for other widgets. The table I will work on a separate PR. There is a bug that needs to be fixed before the padding looks good on it. When there is a title and descriptions, the right table edge is adjustable, which is not expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p-4) viaCanvasComponent, eliminating inconsistent per-widget paddingleading-noneacross all widgets viaComponentHeaderrounded-[6px],outlinereplaced withborder+shadowfor cleaner card appearanceCanvasChart,LeaderboardDisplay,CanvasPivotDisplay) now follow a uniformsize-full flex flex-col gap-y-4pattern for consistent 16px gap between title and contentCanvasPivotRendererandVegaLiteRendererpadding: 0in Vega config for canvas dashboards to eliminate Vega-Lite's default internal 5px padding, aligning Y-axis labels with card titlesChecklist:
Developed in collaboration with Claude Code