Skip to content

chore: rivetkit to rust#4679

Draft
NathanFlurry wants to merge 59 commits intofeat/sqlite-vfs-v2from
04-16-chore_rivetkit_to_rust
Draft

chore: rivetkit to rust#4679
NathanFlurry wants to merge 59 commits intofeat/sqlite-vfs-v2from
04-16-chore_rivetkit_to_rust

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 18, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Apr 18, 2026
11 tasks
@railway-app
Copy link
Copy Markdown

railway-app bot commented Apr 18, 2026

🚅 Deployed to the rivet-pr-4679 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Apr 21, 2026 at 1:20 am
kitchen-sink ❌ Build Failed (View Logs) Web Apr 20, 2026 at 12:08 am
frontend-cloud ❌ Build Failed (View Logs) Web Apr 19, 2026 at 7:39 pm
frontend-inspector ❌ Build Failed (View Logs) Web Apr 19, 2026 at 7:39 pm
ladle ❌ Build Failed (View Logs) Web Apr 18, 2026 at 9:39 pm
mcp-hub ✅ Success (View Logs) Web Apr 18, 2026 at 9:38 pm

@claude
Copy link
Copy Markdown

claude bot commented Apr 18, 2026

PR 4679 Review - rivetkit to rust migration (draft, ~47K additions)

BLOCKING ISSUES

  1. Mutex-HashMap Violations
    CLAUDE.md requires scc::HashMap, never Mutex-HashMap. Six violations found:
  • rivetkit-rust/packages/rivetkit-core/src/actor/queue.rs: completion_waiters
  • rivetkit-typescript/packages/rivetkit-napi/src/bridge_actor.rs:22-30: ResponseMap, WsSenderMap, SqliteStartupMap, SqliteSchemaVersionMap
    All should use scc::HashMap to avoid lock contention.
  1. destroy_actor and stop_actor Send Identical Intent
    engine/sdks/rust/envoy-client/src/handle.rs:71-87: Both send ActorIntentStop. If destroy_actor should permanently remove an actor, this is a bug. If intentional, consolidate or document equivalence.

  2. Placeholder Sandbox Documentation
    website/src/content/docs/actors/sandbox.mdx contains only a placeholder. Before landing: complete docs, remove from sitemap, or redirect to working alternative.

MINOR ISSUES

  • Queue payloads support only v4 while actor state supports v3+v4. Add comment confirming intentional.
  • counter.rs: initialize_schema is a no-op (SQLite unfinished). Mark WIP or gate behind feature flag.

STRENGTHS

  • scc::HashMap used correctly in RegistryDispatcher (active_instances, stopping_instances)
  • moka::Cache for SQLite page cache
  • Structured tracing throughout, no bare println!/eprintln!
  • Versioned persistence pattern (encode_with_embedded_version / decode_with_embedded_version) cleanly applied
  • Real-process NAPI integration tests, no module-level mocking
  • Two-phase factory pattern and Arc-ActorContext ownership model are clean

Gate test-only `NEXT_STAGE_ID` and `next_stage_id()` with `#[cfg(test)]`
in sqlite-native vfs.rs. Apply biome formatting to native.ts and
rivetkit-napi index.d.ts.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant