Skip to content

Fix TODO - mypy ignored modules#2172

Open
omkar-334 wants to merge 3 commits intoroboflow:developfrom
omkar-334:fix/mypy-ignored-modules
Open

Fix TODO - mypy ignored modules#2172
omkar-334 wants to merge 3 commits intoroboflow:developfrom
omkar-334:fix/mypy-ignored-modules

Conversation

@omkar-334
Copy link
Contributor

Before submitting
  • Self-reviewed the code
  • All tests pass locally

Description

  • pyproject.toml — removed 3 stale ignore_errors overrides for smoother, skeletons, metrics.utils.utils
    • key_points/skeletons.py — removed Edges type annotations from 4 enum members (mypy requires enum members to be unannotated)
    • detection/tools/smoother.py — added type annotation for tracks, used cast for getitem return, renamed track → valid to fix type narrowing

Type of Change

  • 🔨 Refactoring (no functional changes)
Screenshot 2026-03-11 at 9 02 24 AM

@omkar-334 omkar-334 requested a review from SkalskiP as a code owner March 11, 2026 03:32
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75%. Comparing base (c010656) to head (15339e2).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2172   +/-   ##
=======================================
  Coverage       75%     75%           
=======================================
  Files           62      62           
  Lines         7545    7546    +1     
=======================================
+ Hits          5648    5649    +1     
  Misses        1897    1897           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant