Add shell chapters, update functions lesson, handle missing Welcome.md#868
Open
DergunNik wants to merge 4 commits intoronreiter:masterfrom
Open
Add shell chapters, update functions lesson, handle missing Welcome.md#868DergunNik wants to merge 4 commits intoronreiter:masterfrom
DergunNik wants to merge 4 commits intoronreiter:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regular Expressions and Special Commands sed,awk,grep,sort chapters were added for shell in English. The Shell Functions lesson was updated.
Welcome.md for Spanish shell was also added, since es already had the Hello World! lesson, but without an appropriate Welcome.md file the server would not boot. This issue existed before my changes, so the current version from GitHub could not be run.
The server failed with the following error (from docker):
It may be worth adding an if check at line 196 in main.py to prevent similar cases in the future: