Try using sip-build and Python3_add_library for Qt5/Qt6#157
Draft
Try using sip-build and Python3_add_library for Qt5/Qt6#157
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm playing around with an alternative to #143.
If I understand correctly, and I'm not sure that I do,
python_qt_bindinguses a Python scriptsip_configure.pyto produce a Makefile that produces a cPython extension. This PR usessip-buildand the CMake functionPython3_add_libraryto build a cPython extension instead.I'm not sure that this works yet. There are too many pieces to test it on Resolute, so I'm going to try iterating on Noble later this week.
I used Gemini 3.1 Pro to help make this PR