remove ament_export_link_flags() for atomic operations.#528
Open
fujitatomoya wants to merge 2 commits intorollingfrom
Open
remove ament_export_link_flags() for atomic operations.#528fujitatomoya wants to merge 2 commits intorollingfrom
fujitatomoya wants to merge 2 commits intorollingfrom
Conversation
fujitatomoya
commented
Mar 13, 2026
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
this approach (linking atomic directly into librcutils.so instead of exporting the flag) solves #525 without regressing #516, because the atomic symbols get baked into the rcutils shared library itself. downstream packages never need to find libatomic on their own, regardless of whether BUILD_TESTING is on or off.
Collaborator
Author
|
@Mergifyio rebase |
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
✅ Branch has been successfully rebased |
fujitatomoya
force-pushed
the
fujitatomoya/issues/525
branch
from
6669cba to
4bb0010
Compare
Collaborator
Author
|
Pulls: #528
|
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #525
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information