fix(docker): use heredoc delimiter for multiline GITHUB_OUTPUT#190
Open
debanjan97 wants to merge 2 commits intomainfrom
Open
fix(docker): use heredoc delimiter for multiline GITHUB_OUTPUT#190debanjan97 wants to merge 2 commits intomainfrom
debanjan97 wants to merge 2 commits intomainfrom
Conversation
The `Get tags and labels for this arch` step wrote multiline tag values using simple `echo "tags=..." >> $GITHUB_OUTPUT`. When there are multiple tags (e.g., version + latest), the second line has no key= prefix and GitHub rejects it as an invalid output format. Switch to the heredoc delimiter syntax (`<<EOF`) so multiline values are handled correctly. PRO-5596 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Scanned-by: gitleaks 8.29.0
Temporary change — revert before merging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Scanned-by: gitleaks 8.29.0
Contributor
Docker Preview Images ReadyPreview Docker images have been built for this PR: ECR (internal): docker pull 422074288268.dkr.ecr.us-east-1.amazonaws.com/rudderstack/profiles-code-server:pr-190Image Details:
Test the image: docker run --rm -p 8080:8080 422074288268.dkr.ecr.us-east-1.amazonaws.com/rudderstack/profiles-code-server:pr-190
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
latesttag added in #188 made the metadata outputs multiline. TheGet tags and labels for this archstep wrote these withecho "tags=..." >> $GITHUB_OUTPUT, but when the value spans multiple lines the second line lacks akey=prefix and GitHub rejects it:Summary
echo "key=value"to the heredoc delimiter syntax (key<<EOF) for writing multiline tags and labels to$GITHUB_OUTPUTTest plan
v<VERSION>andlatesttags are produced without output errorsResolves PRO-5596
🤖 Generated with Claude Code