Open
Conversation
Co-authored-by: WolverinDEV <git@did.science>
Co-authored-by: Çağatay Yiğit Şahin <cyigitsahin@outlook.com>
env_filter Some parts of the tests are skipped with no_std as they require `snapbox::str!` which does not support no_std.
cagatay-y
changed the title
epage
reviewed
Apr 2, 2026
Comment on lines
40
to
44
| #![cfg_attr(docsrs, feature(doc_cfg))] | ||
| #![cfg_attr(not(feature = "std"), no_std)] | ||
| #![warn(missing_docs)] | ||
| #![warn(clippy::print_stderr)] | ||
| #![warn(clippy::print_stdout)] |
Contributor
There was a problem hiding this comment.
For a no-std crate, I would expect the following lints added
#![warn(clippy::std_instead_of_core)]
#![warn(clippy::std_instead_of_alloc)]
epage
reviewed
Apr 2, 2026
.github/workflows/ci.yml
Outdated
Comment on lines
+75
to
+81
| run: | ||
| - cargo hack check --each-feature --locked --rust-version --ignore-private --package env_logger --all-targets --keep-going | ||
| # When the std feature is enabled, a lower MSRV of 1.71 is sufficient and was the MSRV for the crate before std was made optional. | ||
| # To make sure we keep it that way, check configurations with std enabled and disabled separately and with their respective MSRVs. | ||
| # "--at-least-one-of" requires "--feature-powerset", which can be made to emulate "--each-feature" with "--depth 1". | ||
| - cargo hack check --feature-powerset --depth 1 --locked --version-range 1.71..=1.71 --ignore-private --package env_filter --all-targets --keep-going --at-least-one-of std,default,regex | ||
| - cargo hack check --no-default-features --locked --version-range 1.81..=1.81 --ignore-private --package env_filter --all-targets --keep-going |
Contributor
There was a problem hiding this comment.
- This is too complicated
- I am not keen on having feature-dependent MSRVs
Contributor
|
FYI I expect PRs to be presented for how they should be reviewed and merged and not for how they were developed. Please clean up the commit history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #378, this PR adds a new default feature
stdthat allows the crate to be used in no_std crates. I tried to incorporate the feedback that was given to the previous PR. Hopefully, I didn't miss anything.The PR is still a breaking change for crates that have the default features disabled and use
Builder::from_env, or expectBuilder::parseto print warnings to stderr and don't have the log target set to stderr.It may make sense to squash 9c70eaf and 663c9c2 (and potentially b754c66). I kept them separate to make sure I don't misattribute the work of the author of the base PR.